feat(monero): enable local monero nodes while Tor is enabled via a "Bypass TOR" node option #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneurlax
changed the title
Member
Author
|
We may need to add a warning, because when Tor is enabled but this new (false by default) "Bypass TOR" setting is checked, Stack Wallet will use the local node however it's configured--including over clearnet when they may expect that just enabling Tor in Stack Wallet will "Torify" everything (like when using eg. torsocks) |
chore: whitespace fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1124
The above "Bypass TOR" checkbox is only visible when the node host contains the string
localhostor127.0.0.1.